added Cluster Settings v2 Update for Cassandra #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengu-alt
approved these changes
Aug 14, 2023
worryg0d
reviewed
Aug 15, 2023
Comment on lines
+145
to
+146
| if len(old) == 0 && len(new) == 0 || | ||
| len(old) == 0 && len(new) == 1 { |
There was a problem hiding this comment.
Instead of double check, you can do:
if len(old) == 0 && len(new) < 2 {
return nil
}
There was a problem hiding this comment.
I just want to explicitly show that the new object can be validated successfully as if it were empty or with only one object populated. len(new) < 2 is cleaner but less readable imho.
worryg0d
approved these changes
Aug 15, 2023
testisnullus
approved these changes
Aug 15, 2023
ribaraka
changed the title
taaraora
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #521
descriptionto all clusters CRDsupdate2FD and description